search

paypal / junodb

JunoDB is PayPal's home-grown secure, consistent and highly available key-value store providing low, single digit millisecond, latency at any scale.
Apache License 2.0
2.56k stars 164 forks source link

go.mod should use fully qualified module path #113

Open justinfx opened 1 year ago

justinfx commented 1 year ago

The go.mod file says module juno, where it should be updated to module github.com/paypal/junodb to be "go get" compatible and properly document the client on pkg.go.dev

Ahmadkashif commented 1 year ago

Hi @justinfx , I would like to work on this.

Ahmadkashif commented 1 year ago

Hi @justinfx, take a look at what I tried, it might be a little off as I only had a 1-liner issue description. Let me know if it is what you wanted.

justinfx commented 1 year ago

Hi @Ahmadkashif. Sorry if my description wasn't clear. I had assumed the issue was pretty straightforward via the common Go module documentation. But I hadn't considered you would have also needed to update all of the import paths as well. So definitely not a one line change. Good thing IDE refactoring usually handles it all in one step, and the compiler checks it as well. Changes look good to me!

justinfx commented 1 year ago

Ref: https://go.dev/ref/mod#module-path

Ahmadkashif commented 1 year ago

I'm happy to help @justinfx .

Let's get the ball rolling.