search

paypal / junodb

JunoDB is PayPal's home-grown secure, consistent and highly available key-value store providing low, single digit millisecond, latency at any scale.
Apache License 2.0
2.56k stars 163 forks source link

Why is keyrange deletion operation present twice? #136

Closed uds5501 closed 1 year ago

uds5501 commented 1 year ago

In pkg/etcd/etcdwriter.go I can see that we are putting a deletion operation twice with the same key range, is this an intended behaviour or missed refactor?

https://github.com/paypal/junodb/blob/bd25f8c76f511b5c59c688e97e78f8b7a53b6845/pkg/etcd/etcdwriter.go#L57-L73

PS : Apologies If this does not follow standard issue raising templates, couldn't find one in developer guidelines.

uds5501 commented 1 year ago

Ignore, I just noticed both the objects are different when assigned to begin and endKey