search

paypal / load-watcher

Load watcher is a cluster-wide aggregator of metrics, developed for Trimaran: Real Load Aware Scheduler in Kubernetes.
Other
63 stars 33 forks source link

Bump dep version for "github.com/prometheus/common" #39

Closed Huang-Wei closed 2 years ago

Huang-Wei commented 2 years ago

The code below

https://github.com/paypal/load-watcher/blob/1c92ae3f9346943cb3694e7de24c95f851508b61/pkg/watcher/internal/metricsprovider/prometheus.go#L66

is no longer valid in the latest Prometheus library.

The code should be refactored to:

config.NewAuthorizationCredentialsRoundTripper("Bearer", token, rt)

This is found when I wanted to bump the version of scheduler-plugins to k8s 1.22.

zorro786 commented 2 years ago

@wangchen615 Could you please look into upgrading Prometheus library to v0.26.0 from v0.15.0?

Huang-Wei commented 2 years ago

@zorro786 I just raised a PR :)