search

paypal / load-watcher

Load watcher is a cluster-wide aggregator of metrics, developed for Trimaran: Real Load Aware Scheduler in Kubernetes.
Other
63 stars 33 forks source link

Added InsecureSkipVerify option and code to support EnableOpenShiftAuth=True env configuration #49

Closed wangchen615 closed 2 years ago

wangchen615 commented 2 years ago

This commit will introduce InsecureSkipVerify option for MetricProvider, so developers can choose to skip the verification of HTTPs requests by adding InsecureSkipVerify: True for Prometheus queries. This is particular useful for clusters running on GCP and AWS as they by default do not allow HTTPs access with tokens.

We also add support to enable OpenShift Authentications for OpenShift clusters via allowing developers to configure environment variable EnableOpenShiftAuth=True.

This will resolve and close issue #48

wangchen615 commented 2 years ago

/hold

ridv commented 2 years ago

This should be configurable. Skipping TLS cert verification should not be a default.

wangchen615 commented 2 years ago

This should be configurable. Skipping TLS cert verification should not be a default.

@ridv the configurable SkipInsecureVerify field is added.

/unhold

wangchen615 commented 2 years ago

Added both InsecureSkipVerify and EnableOpenShiftAuth options to the authentication of prometheus client to resolve issue: #48

zorro786 commented 2 years ago

@wangchen615 Please update the PR title and description.

wangchen615 commented 2 years ago

@zorro786 , I fixed all issues related to the opt arg, indentations, and format. I also updated the description. Please help take another review.