Closed jpedro1992 closed 1 year ago
I dont think we need to add vendor to the repo right?
I can remove the vendor dependencies by doing a reset if you prefer. What do you think?
is it still compiled (generated) without the vendor? If so, please go ahead.
Well, I need to run go mod vendor
to be able to run a few tests (e.g., watcher_test.go
).
Several dependencies needed an update.
which go version are you using? I think we can skip vendor as anyone can generate it for building and testing.
which go version are you using? I think we can skip vendor as anyone can generate it for building and testing.
I am using go 1.16. I just removed the vendor dependencies from the PR and I squashed both commits into a single one.
@wangchen615 can you approve this PR, it needs your approval.
/close issue #58
What type of PR is this?
Addition of bandwidth and storage metrics in load-watcher.
Related issue
58
Summary
Additional metrics: