paypal / load-watcher

Load watcher is a cluster-wide aggregator of metrics, developed for Trimaran: Real Load Aware Scheduler in Kubernetes.
Other
63 stars 33 forks source link

Support of Bandwidth and Storage metrics #59

Closed jpedro1992 closed 1 year ago

jpedro1992 commented 1 year ago

What type of PR is this?

Addition of bandwidth and storage metrics in load-watcher.

Related issue

58

Summary

Additional metrics:

promTransBandMetric     = "instance:node_network_transmit_bytes:rate:sum"
promTransBandDropMetric = "instance:node_network_transmit_drop_excluding_lo:rate5m"
promRecBandMetric       = "instance:node_network_receive_bytes:rate:sum"
promRecBandDropMetric   = "instance:node_network_receive_drop_excluding_lo:rate5m"
promDiskIOMetric        = "instance_device:node_disk_io_time_seconds:rate5m"
lenhattan86 commented 1 year ago

I dont think we need to add vendor to the repo right?

jpedro1992 commented 1 year ago

I can remove the vendor dependencies by doing a reset if you prefer. What do you think?

lenhattan86 commented 1 year ago

is it still compiled (generated) without the vendor? If so, please go ahead.

jpedro1992 commented 1 year ago

Well, I need to run go mod vendor to be able to run a few tests (e.g., watcher_test.go).

Several dependencies needed an update.

lenhattan86 commented 1 year ago

which go version are you using? I think we can skip vendor as anyone can generate it for building and testing.

jpedro1992 commented 1 year ago

which go version are you using? I think we can skip vendor as anyone can generate it for building and testing.

I am using go 1.16. I just removed the vendor dependencies from the PR and I squashed both commits into a single one.

lenhattan86 commented 1 year ago

@wangchen615 can you approve this PR, it needs your approval.

wangchen615 commented 1 year ago

/close issue #58