Broken XML produced for SetExpressCheckout request when using "cpp*" fields

paypal / merchant-sdk-php

PHP SDK for integrating with PayPal's Express Checkout / MassPay / Web Payments Pro APIs

Other

231 stars 201 forks source link

Broken XML produced for SetExpressCheckout request when using "cpp*" fields #136

Closed piazzon-f closed 7 years ago

piazzon-f commented 7 years ago

General information

SDK/Library version: 3.11.0
Environment: tested only in Sandbox

Issue description

PSR compliant linting in commit c9a15d773fcbca7f052b7524c9103889142fa552 modified the @name annotation for "cpp" fields in SetExpressCheckoutRequestDetailsType.php introducing a space character that has broken the resulting XML request output when one of the cpp fields is specified.

gerardnll commented 7 years ago

Bug also present in 3.10.0, I rolled back to 3.9.1.

jaypatel512 commented 7 years ago

Hey @piazzon-f @gerardnll ! I have created a PR fixing this. Can you please help me review it, and make sure I have not missed anything else.