search

paypal / merchant-sdk-php

PHP SDK for integrating with PayPal's Express Checkout / MassPay / Web Payments Pro APIs
Other
230 stars 201 forks source link

Changed name of class because deprecation with composer v2 #163

Closed victormln closed 2 years ago

victormln commented 4 years ago

Composer v2 is coming soon, so when you try to install this library, you receive a Deprecation notice:

Deprecation Notice: Class PayPal\EBLBaseComponents\BillingPeriodDetailsType_Update located in ./vendor/paypal/merchant-sdk-php/lib/PayPal/EBLBaseComponents/BillingPeriodDetailsType_Update.php does not comply with psr-0 autoloading standard. It will not autoload anymore in Composer v2.0. in phar:///usr/local/bin/composer/src/Composer/Autoload/ClassMapGenerator.php:201

In order to have PSR-0 standard (https://www.php-fig.org/psr/psr-0/#mandatory) we should create a directory: BillingPeriodDetailsType/Update.php but I think that in this is case is better: BillingPeriodDetailsTypeUpdate.php

Fixes: #161

jaypatel512 commented 4 years ago

Quick question: wouldn't this be a breaking change ? If so, we may have to make a major version upgrade.

victormln commented 4 years ago

Hi @jaypatel512 , yes you will need to make a major version upgrade (3.13.x). I think it's better because there will be no duplicate files and you can "start from zero". You can update also the README.md to require the last version (currently is 3.8.x but you have 3.12.x).

Thank you!

stilliard commented 4 years ago

@victormln looks like your PR renames the package in the composer file.

@jaypatel512 do you know who can get this merged?

devchristina commented 2 years ago

Closing due to lack of support, this repo will be archived.