search

paypal / merchant-sdk-php

PHP SDK for integrating with PayPal's Express Checkout / MassPay / Web Payments Pro APIs
Other
231 stars 201 forks source link

Usage of sdk-core-php results in E_DEPRECATED warnings #166

Closed stilliard closed 2 years ago

stilliard commented 4 years ago

General information

Issue description

Hey :wave:

This repo uses paypal/sdk-core-php in the composer file which appears to be deprecated / archived by paypal.

As this repo isn't yet marked as deprecated / archived, is there any way to get a fix made to sdk-core-php as it's used here and both are under the paypal account?

It's causing E_DEPRECATED: Cannot use "parent" when current class scope has no parent warnings in production, ref https://github.com/paypal/sdk-core-php/issues/118

Thank you.

hahazyb201 commented 4 years ago

When will this pull request be merged into the paypal/sdk-core-php? https://github.com/paypal/sdk-core-php/pull/117 . I am having the same issue which breaks my unit tests in php 7.4.

closb commented 4 years ago

same here, guess we're on our own!

BafS commented 4 years ago

We did a fork there: https://github.com/ProtonMail/sdk-core-php

Available on packagist too: https://packagist.org/packages/protonlabs/paypal-sdk-core-php

pyrou commented 3 years ago

ping @bluk (as you are the last known merger of the paypal/sdk-core-php repo)

bluk commented 3 years ago

@pyrou Sorry, I have not worked at PayPal for some time. My recommendation is to contact PayPal technical support ( https://developer.paypal.com/support/ ).

stilliard commented 3 years ago

Hi @bluk, Thanks anyway.

For anyone else on this thread or finding this later:

I reached out to PayPal technical support, thinking maybe the current devs are busy working on other projects atm. Here's their reply:

Thank you for contacting Merchant Technical Support.

I understand that you are proposing a revision to the PayPal PHP SDK due to changes within PHP version 8; sorry for any confusion surrounding this. Per the information at https://github.com/paypal/merchant-sdk-php :

image

I see that there was a recent comment in the github issues link where one of the contributors believes that our team may be able to assist, but our team does not make contributions to the SDKs. Rather, it is the role of PayPal's Merchant Technical Support team to troubleshoot and/or escalate when merchants are encountering errors/outages within PayPal's servers (not at the merchant's local end), and that we do not assist in making changes to the various SDKs.

I would recommend continuing to post at https://github.com/paypal/merchant-sdk-php/issues where hopefully one of the other contributors will be able to assist. As this issue is not related to a technical issue occurring within the servers at PayPal's end, I am proceeding to close this case.

Thank you, Richard Merchant Technical Services

They closed off the ticket, I replied asking if there's anyone they can send the request onto but as it's closed I'm not expecting a reply. Feel free for anyone else to try chasing up too.

Think for now the best option is to use a Fork such as the one @BafS mentioned.

devchristina commented 2 years ago

Closing due to lack of support