search

paypal / mocca

Mocca is a GraphQL client for JVM languages with the goal of being easy to use, flexible and modular.
MIT License
15 stars 14 forks source link

Code quality/static analysis/etc tool integration #5

Open crankydillo opened 3 years ago

crankydillo commented 3 years ago

Codacy is a top candidate.

Before configuring Codacy (or any similar tool), it is necessary first to configure Jacoco in Mocca. Jacoco configuration was actually already present in the original version of Mocca. However, it had to be removed (see this commit) during a Gradle upgrade because it was incompatible with Gradle 7.1.

fabiocarvalho777 commented 3 years ago

A few useful notes:

  1. Before integrating with Codacy, we need to enable Jacoco first. Mocca used to have Jacoco configuration, but that got removed when we upgraded version from version 5 to 7 (see commit in the description).
  2. Here you can see how to enable Codacy during Travis CI builds (Codacy CODACY_PROJECT_TOKEN auth token environment variable also needs to be added in Travis CI).
  3. Add two Codacy badges (project quality and code coverage) as part of this issue.
crankydillo commented 3 years ago

@fabiocarvalho777 If easy, are you willing to do this? I have some reasons why I don't want to do this right now:)

fabiocarvalho777 commented 3 years ago

@crankydillo I am too busy working with https://github.com/OpenFeign/feign/issues/1448.

@abhijith-prabhakar could you work on this issue?