search

paypal / nemo-screenshot

Plugin for Nemo testing framework for adapting selenium screenshot capabilities
Other
12 stars 26 forks source link

updates depends, updates license #36

Closed gabrielcsapo closed 8 years ago

gabrielcsapo commented 8 years ago

code cleanup

LM-NYC-00875272:nemo-screenshot gacsapo$ npm test

> nemo-screenshot@2.0.0 test /Users/gacsapo/Documents/nemo/nemo-screenshot
> grunt

Running "simplemocha:all" (simplemocha) task

  nemo-screenshot
    ✓ will get @setup@
    ✓ will use @snap@ to take a screenshot (494ms)
    ✓ will use @done@ to take a screenshot (66ms)
    ✓ will use @done@error@ to take a screenshot in an error scenario (62ms)

  4 passing (2s)

Running "jshint:files" (jshint) task
>> 2 files lint free.

Done.

fixes #31, #30

gabrielcsapo commented 8 years ago

@OuranosSkia and @grawk would you be able to verify these changes? I will squash commits into one commit if this is satisfactory

OuranosSkia commented 8 years ago

Looks good to me! 👍

gabrielcsapo commented 8 years ago

@OuranosSkia and @grawk I squashed the commits into one, let me know if anything needs to be changed

grawk commented 8 years ago

https://github.com/paypal/nemo-docs/blob/master/contributing.md#strings

Unless we are agreeing to change this convention, some of the changes in this PR pull us away from the convention.

gabrielcsapo commented 8 years ago

@grawk will update PR to use single quotes instead of double quotes

gabrielcsapo commented 8 years ago

@grawk updated the PR to have single quotes instead of double, updated my squashed commit.

grawk commented 8 years ago

Ugh. Sorry, I just realized two things. 1. this PR should be opened against develop. 2. master is not up to date with develop.

SO, let's open this up against develop and close this PR. Unless there are any merge conflicts it should be a really simple merge there.

Then I'll make sure to PR master -> develop.