fix exception silenced when autocapture on exception is enabled

paypal / nemo-screenshot

Plugin for Nemo testing framework for adapting selenium screenshot capabilities

Other

12 stars 26 forks source link

Closed jugend closed 8 years ago

jugend commented 8 years ago

Issue caused by a bug in Selenium driver, fixed in 3.x, but not 2.x: https://github.com/SeleniumHQ/selenium/issues/2770

Implication may cause Mocha timeout error with done not called.

grawk commented 8 years ago

:+1:

grawk commented 8 years ago

Seems there is a merge conflict to resolve. Will have to do this manually, upon another approval.

jugend commented 8 years ago

Rebased, thanks!

gabrielcsapo commented 8 years ago

:+1: nice!

grawk commented 8 years ago

Shoot. @jugend can you please close this PR and open against develop?