Send 'production' over 'live' to FPTI

paypal / paypal-ios

One merchant integration point for all of PayPal's services

Apache License 2.0

59 stars 27 forks source link

Send 'production' over 'live' to FPTI #171

Closed scannillo closed 1 year ago

scannillo commented 1 year ago

Reason for changes

While creating analytics dashboards, we realized that the BT & PPCP SDKs differ in the values we are sending for the merchant_sdk_env key to FPTI
- BT Mobile SDKs are sending: production & sandbox, PPCP mobile SDKs are sending live & sandbox

Summary of changes

Send production over live in FPTI post body

Checklist

~Added a changelog entry~

Authors

@scannillo

scannillo commented 1 year ago

We technically could change the BT SDKs to send live, but Jax mentioned that PayPal uses the term "production" as well. I personally don't feel strongly about which SDK gets this change. Happy to do it in BT instead if folks prefer keeping this as-is.

scannillo commented 1 year ago

Closing in favor of - https://github.com/braintree/braintree_ios/pull/1083