[PART 2] Networking Refactor - Unify `REST` & `GraphQL` networking implementation - Githubissues

paypal / paypal-ios

One merchant integration point for all of PayPal's services

Apache License 2.0

59 stars 27 forks source link

[PART 2] Networking Refactor - Unify `REST` & `GraphQL` networking implementation #182

Closed scannillo closed 1 year ago

scannillo commented 1 year ago

Reason for changes

Follow up to #177.

This PR:

Standardizes the interface for making REST & GraphQL requests from the feature client's perspective
Unifies REST & GraphQL requests to use the same underlying HTTP, URLRequest, and URLSession implementations
Repurposes APIClient (which previously just passed requests along to HTTP) into a true NetworkingCoordinator that transforms REST & GraphQL --> HTTP.

Summary of changes

Add fetch(request: GraphQLRequest) method to APIClient
- This class now has only 2 public functions, an equivalent for REST & GraphQL
Remove GraphQLClient and other no-longer-used GraphQL files
Rename GraphQLQueryResponse --> GraphQLHTTPResponse

Next

Rename APIClient to NetworkingClient
Unit Tests
Add VaultPaymentMethodTokensAPI class (waiting on Victoria's #172 PR to merge)
Update parsing layer for GraphQL (see TODOs)

Note

Tests are expected to fail.

Checklist

~Added a changelog entry~

Authors

@scannillo