These changes have already been reviewed in this series of PRs. I created this PR solely to confirm CI passes.
:warning: Do not squash and merge
Summary
These PRs re-architect our networking layer to allow for re-use between GraphQL and REST request implementation. We can now use the same underlying HTTP layer for each request, in addition to a single implementation of Apple's URLSession, URLRequest, JSONDecoder, & JSONEncoder.
This reduces duplication, and increases testability of each layer through removing heavy logic that previously lived in protocol extensions. This also unifies our APIs for making a REST & GraphQL request from the feature client level.
Before
After
Next Steps
We need to create JIRAs for the following tasks:
Renaming APIClient --> NetworkingClient
Creating a wrapper/ custom JSONEncoder layer
Re-organize file structure in Sources
Decide on consistent naming convention for model (struct) request types
Reason for changes
These changes have already been reviewed in this series of PRs. I created this PR solely to confirm CI passes.
:warning: Do not squash and merge
Summary
These PRs re-architect our networking layer to allow for re-use between GraphQL and REST request implementation. We can now use the same underlying HTTP layer for each request, in addition to a single implementation of Apple's URLSession, URLRequest, JSONDecoder, & JSONEncoder.
This reduces duplication, and increases testability of each layer through removing heavy logic that previously lived in protocol extensions. This also unifies our APIs for making a REST & GraphQL request from the feature client level.
Next Steps
We need to create JIRAs for the following tasks:
Sources
Checklist
Authors
@scannillo