search

paypal / paypal-ios

One merchant integration point for all of PayPal's services
Apache License 2.0
59 stars 27 forks source link

Remove PayPalCheckout dependency from Demo #204

Closed scannillo closed 1 year ago

scannillo commented 1 year ago

Reason for changes

The PPCP SDK pulls in NXO directly so there is no need for a merchant app to be directly fetching the NXO package.

Summary of changes

Checklist

Authors

@scannillo

scannillo commented 1 year ago

Dang, our Demo app still needs refactoring to remove usage of PayPalCheckout. We have a separate ticket for this work - DTPPCPSDK-501.

sshropshire commented 1 year ago

Dang, our Demo app still needs refactoring to remove usage of PayPalCheckout. We have a separate ticket for this work - DTPPCPSDK-501.

Yoo that might fix the Archive bug. But on second thought I guess we'd have to remove the SPM build flags as well. Not sure if Xcode does that automatically.

scannillo commented 1 year ago

@sshropshire Yoo that might fix the Archive bug. But on second thought I guess we'd have to remove the SPM build flags as well. Not sure if Xcode does that automatically.

Exactly yeh, that's why I thought we should do this first. But then it ended up revealing that our Demo app is using PayPalCheckout components for the model layer, which we need to refactor and then rip out the NXO dependency in the Demo.

New Xcode projects that don't include any SPM packages don't include the macro flag. I was hoping that removing the package would remove the macro, but it didn't. We should be safe to remove it manually though!