search

paypal / paypal-ios

One merchant integration point for all of PayPal's services
Apache License 2.0
59 stars 27 forks source link

Add custom corner radius for PaymentButtons #229

Closed vradopp closed 9 months ago

vradopp commented 10 months ago

Reason for changes

To allow consumers of the SDK to use a custom cornerRadius for the PaymentButton

Summary of changes

Checklist

Authors

List GitHub usernames for everyone who contributed to this pull request.

scannillo commented 10 months ago

Changes LGTM! Wanted to call out that we technically can target this for main since this is an additive change, not a breaking change.

I also understand if we want to keep all PaymentButton related changes in V2, though

scannillo commented 9 months ago

Looks like this equivalent change went into main (V1) on Android (see PR). We should keep this consistent across platforms.