paypal / paypal-ios

One merchant integration point for all of PayPal's services
Apache License 2.0
59 stars 27 forks source link

Deprecated and updated colors for Payment Buttons #231

Closed stechiu closed 9 months ago

stechiu commented 10 months ago

Reason for changes

As part of QL button redesign requirements, we are consolidating colors to gold and white

Summary of changes

https://github.com/paypal/paypal-ios/assets/127455800/44df0106-78bd-45eb-81a6-3637b86400b2

Checklist

Authors

List GitHub usernames for everyone who contributed to this pull request.

scannillo commented 10 months ago

I think instead we want to mark the existing colors as deprecated on main (V1), and then remove those enum cases entirely in next-major-version (V2).

This gives our merchants on V1 a notice that they should stop using these buttons and that they will be removed when they upgrade to V2.

stechiu commented 10 months ago

I think instead we want to mark the existing colors as deprecated on main (V1), and then remove those enum cases entirely in next-major-version (V2).

This gives our merchants on V1 a notice that they should stop using these buttons and that they will be removed when they upgrade to V2.

That's a good idea. I'll change the base to main and open another PR where the buttons are removed on next-major-version branch