search

paypal / paypal-ios

One merchant integration point for all of PayPal's services
Apache License 2.0
59 stars 27 forks source link

Updated with PayPalOpen font #237

Closed stechiu closed 8 months ago

stechiu commented 9 months ago

Reason for changes

Need to update fonts for Payment Buttons to PayPalOpen font as the primary font as part of QL.

Figma PR
Screenshot 2024-01-08 at 12 01 09 PM Screenshot 2024-01-08 at 12 01 30 PM

Summary of changes

Checklist

Authors

List GitHub usernames for everyone who contributed to this pull request.

@stechiu

stechiu commented 9 months ago

Since the change is in the font typeface and isn't breaking, nor do Merchants need to make any changes, does the change still need to be included in the CHANGELOG?

scannillo commented 9 months ago

Since the change is in the font typeface and isn't breaking

I would classify changing UI without a merchant having to opt-in to that change, as a breaking change. Even though it's super minor (in this case of a font that doesn't look too different), by the book it would be breaking.

We could classify this is a "bug-fix to meet brand guidelines" if we want to get it into V1 😆. Sketchy? Thoughts?

jaxdesmarais commented 9 months ago

We could classify this is a "bug-fix to meet brand guidelines" if we want to get it into V1 😆. Sketchy? Thoughts?

I think classifying this as a bug fix makes sense! I assume there is some "brand reputation" to actually using the correct fonts so could make sense for a minor version + changelog update.

stechiu commented 9 months ago

Since the change is in the font typeface and isn't breaking

I would classify changing UI without a merchant having to opt-in to that change, as a breaking change. Even though it's super minor (in this case of a font that doesn't look too different), by the book it would be breaking.

We could classify this is a "bug-fix to meet brand guidelines" if we want to get it into V1 😆. Sketchy? Thoughts?

Got it, that makes sense! I read through the Semantic Versioning Guideline and must've overlooked UI related changes. In that case, we can have it go into V2 where we have other breaking changes instead.

scannillo commented 9 months ago

must've overlooked UI related changes

You definitely didn't! UI specific stuff isn't clearly defined in there.

I like Jax's thoughts - I'm also down for lumping into V1!