paypal / paypal-ios

One merchant integration point for all of PayPal's services
Apache License 2.0
59 stars 27 forks source link

Removed Buttons colors for V2 #243

Closed stechiu closed 8 months ago

stechiu commented 9 months ago

Reason for changes

We will remove the deprecated colors in V2

Summary of changes

Checklist

Authors

List GitHub usernames for everyone who contributed to this pull request.

warmkesselj commented 9 months ago

@stechiu does this enum embedded in PayPalButton need updating?


    /// Available colors for PayPalButton.
    public enum Color: String {
        case gold
        case white
        case black
        case silver
        case blue

        var color: PaymentButtonColor {
            PaymentButtonColor(rawValue: rawValue) ?? .gold
        }
    }
stechiu commented 9 months ago

@stechiu does this enum embedded in PayPalButton need updating?

    /// Available colors for PayPalButton.
    public enum Color: String {
        case gold
        case white
        case black
        case silver
        case blue

        var color: PaymentButtonColor {
            PaymentButtonColor(rawValue: rawValue) ?? .gold
        }
    }

Missed this one, thanks!

jaxdesmarais commented 9 months ago

It looks like we will also need to clean up the demo app with these changes. See: https://github.com/paypal/paypal-ios/blob/157712a6b10849ac105acdac0e24be995211657a/Demo/Demo/Extensions/PaymentButtonEnums%2BExtension.swift#L14