search

paypal / paypal-ios

One merchant integration point for all of PayPal's services
Apache License 2.0
59 stars 27 forks source link

Refactored `PaymentButton` name - `Edges` to `Shape` #252

Closed stechiu closed 8 months ago

stechiu commented 8 months ago

Reason for changes

JS and Android don't use the parameter edges to describe their button shapes. Instead, they use the parameter shape and the values rectangle (rect for JS), rounded, and pill. This PR is for parity in naming among iOS, Android, and JS.

Summary of changes

Before After
PaymentButtonEdges PaymentButtonShape
hardEdges rectangle
softEdges rounded
rounded pill

Checklist

Authors

List GitHub usernames for everyone who contributed to this pull request.

stechiu commented 8 months ago

Blocking as this is currently a breaking change on main

@jaxdesmarais Issues should be fixed now. I had originally branched from main and when I changed the branch to point to next-major-version, there were many bad merges. Please check to make sure I got them all!