search

paypal / paypal-ios

One merchant integration point for all of PayPal's services
Apache License 2.0
59 stars 27 forks source link

Update Environment URLs #256

Closed sshropshire closed 7 months ago

sshropshire commented 8 months ago

Summary of changes

Authors

List GitHub usernames for everyone who contributed to this pull request.

KunJeongPark commented 8 months ago

Steven, what do you think about the fact that confirm-payment-source and updateSetupToken return url's without -m

sshropshire commented 8 months ago

Steven, what do you think about the fact that confirm-payment-source and updateSetupToken return url's without -m

If the API response contains links with api instead of api-m it's probably fine. I'm going off that document that Tim shared that says to prefer the -m URLs for communicating with PayPal APIs.

jaxdesmarais commented 7 months ago

Just worth calling out that we recently removed the -m on BT iOS and BT Android. Not sure if it's worth digging more into the why. It seems like Sammy discovered it wasn't needed, but maybe that mainly applies to FPTI?

scannillo commented 7 months ago

Just worth calling out that we recently removed the -m on https://github.com/braintree/braintree_ios/pull/1175 and https://github.com/braintree/braintree_android/pull/896. Not sure if it's worth digging more into the why. It seems like Sammy discovered it wasn't needed, but maybe that mainly applies to FPTI?

Yeh, I wasn't able to track down someone on the API side who could speak to what it did differently than without the -m. I saw a Confluence doc, but it was a few years old without much detail. Would love to see what doc Tim was referencing 👀

The main reason though was that PaymentReady doesn't work with -m. Harish, who owns the PaymentReady API, hasn't heard of -m.