paypal / paypal-ios

One merchant integration point for all of PayPal's services
Apache License 2.0
59 stars 27 forks source link

Eligibility Logic skeleton files #283

Closed richherrera closed 3 months ago

richherrera commented 3 months ago

Reason for changes

DTMOBILES-777

Summary of changes

Checklist

Authors

richherrera commented 3 months ago

Nice! Love starting w/ the public API.

We'll need to add docstrings too - can we make a follow up ticket for doing that across iOS & Android (we can re-use the same for both platforms)

I like that plan, thanks!!! created DTMOBILES-853

jaxdesmarais commented 3 months ago

We'll need to add docstrings too - can we make a follow up ticket for doing that across iOS & Android (we can re-use the same for both platforms)

This is in the acceptance criteria for the ticket along with some additional changes not reflected in this PR. Since it's also missing constructing the API call/response, adding to the demo app, adding a changelog entry, and adding unit tests from the AC. @richherrera was the plan to link multiple PRs to 1 ticket for this work?

richherrera commented 3 months ago

We'll need to add docstrings too - can we make a follow up ticket for doing that across iOS & Android (we can re-use the same for both platforms)

This is in the acceptance criteria for the ticket along with some additional changes not reflected in this PR. Since it's also missing constructing the API call/response, adding to the demo app, adding a changelog entry, and adding unit tests from the AC. @richherrera was the plan to link multiple PRs to 1 ticket for this work?

Exactly, that's the plan. I think reviewing PRs would be faster this way, integrating small pieces of code. Multiple PRs will be created to meet all the acceptance criteria of the ticket.