search

paypal / paypalhttp_ruby

MIT License
6 stars 38 forks source link

No Ruby 3 support #12

Closed darkBuddha closed 2 years ago

darkBuddha commented 3 years ago

General information

Issue description

The gem should support the latest Ruby version. It offers major advantages over Ruby 2.

Sexual commented 2 years ago

One potential simple fix for the URI.escape removal?: https://github.com/rollbar/rollbar-gem/pull/988/files

dorianmariecom commented 2 years ago

See #18

or a quick fix:

module URI
  # for PayPal client
  def self.escape(string)
    URI.encode_www_form_component(string).gsub('+', '%20')
  end
end
plerohellec commented 2 years ago

Any chance of getting this fixed now that ruby 3.1 is out?

darkBuddha commented 2 years ago

Any chance of getting this fixed now that ruby 3.1 is out?

https://stripe.com/docs/api?lang=ruby

dorianmariecom commented 2 years ago

stripe doesn't have paypal support ;)

On Mon, Jan 03, 2022 at 19:27:15, darkBuddha < @.*** > wrote:

Any chance of getting this fixed now that ruby 3.1 is out?

https:/ / stripe. com/ docs/ api?lang=ruby ( https://stripe.com/docs/api?lang=ruby )

— Reply to this email directly, view it on GitHub ( https://github.com/paypal/paypalhttp_ruby/issues/12#issuecomment-1004274451 ) , or unsubscribe ( https://github.com/notifications/unsubscribe-auth/AOASD56N5644CM3CQGVOXLLUUHTAHANCNFSM5EFZFU5A ). Triage notifications on the go with GitHub Mobile for iOS ( https://apps.apple.com/app/apple-store/id1477376905?ct=notification-email&mt=8&pt=524675 ) or Android ( https://play.google.com/store/apps/details?id=com.github.android&referrer=utm_campaign%3Dnotification-email%26utm_medium%3Demail%26utm_source%3Dgithub ). You are receiving this because you commented. Message ID: <paypal/paypalhttp_ruby/issues/12/1004274451 @ github. com>

darkBuddha commented 2 years ago

stripe doesn't have paypal support ;)

Stripe doesn't block developers (paying customers) from upgrading their projects...

dorianmariecom commented 2 years ago

you can use the monkey patch or my branch in the fork, or make your own fork. I agree PayPal is technically horrible (the developer docs are the worst website on the internet) but hey people like to use paypal (I do)

darkBuddha commented 2 years ago

you can use the monkey patch or my branch in the fork

Thanks man, great work!

crookedneighbor commented 2 years ago

This is fixed in v2.0.0, which was just released.

darkBuddha commented 2 years ago

Unfortunately the paypal-checkout-sdk gem is now deprecated, and the old versions are incompatible with the recently fixed paypalhttp gem.

If somebody needs this as urgently as I do, please feel free to use my fork.

In the Gemfile:

gem 'paypalhttp', '~> 2.0.0'
gem 'paypal-checkout-sdk', git: 'https://github.com/darkBuddha/Checkout-Ruby-SDK.git', ref: 'f1aab0f4e367aad1de937bba6cbc4abb22900339'

It seems to work fine.

xeruf commented 2 years ago

for good measure, since we can't rely on trust on such a sensitive area as payments, pin the commit on the fork ;)

gem 'paypal-checkout-sdk', git: 'https://github.com/darkBuddha/Checkout-Ruby-SDK.git', :ref => 'f1aab0f4e367aad1de937bba6cbc4abb22900339'