Changed URI.escape to CGI.escape

[cameronlxu]

• In Ruby version 3.x, the URI.escape function becomes deprecated, causing issues that many users will run into.

• Changed the URI.escape function to become CGI.escape as it is more consistent with other projects such as braintree_ruby.

• With this change, the space character now becomes a +, instead of previously being %20.

  • There are also other special/unsafe characters that are also encoded which is showcased below.

• Verified that the deprecation warning logs that appeared in 2.x do not appear in Ruby version 3.x when running tests:

  

• Integration tested this change with the PayPal Checkout-Ruby-SDK and displayed no failures in unit tests.

  • Manually entered in test strings in the access token request body: https://github.com/paypal/Checkout-Ruby-SDK/blob/develop/lib/core/token_requests.rb#L7-L9
  • Temporarily added a print statement in the FormEncoded.rb file to view the results of the CGI.escape workings.

[HDLahlou]

@ganeshramc @tiffanyrzhou Hello, this is Hakim Lahlou from PayPal. We have worked together previously on the PP HTTP SDKs. I was going to reach out to you internally about merging this PR but it seems like you are no longer part of the organization. I was wondering if you still had write access and could proceed with merging this PR in as it is one we did internally. If possible, could you pass on write access to me? If not I am going to try and ask our internal channels about this. Thank you!

[crookedneighbor]

Have y'all verified with the PayPal API teams that switching from %20 to + has no issues?

[josephschito]

This change is huge and LGTM!

[fabn]

This is a very noisy warning and it should be addressed, ruby 2.7 is out for almost 3 years.

[cameronlxu]

@crookedneighbor Thank you! Just added version 1.0.2 with a line about the change.

[camlau-pp-dev]

@crookedneighbor The version has been changed to 2.0.0, please take a review and approve if it looks good!

[camlau-pp-dev]

@crookedneighbor Apologies for the ping again, but since neither I nor Hakim have write access we are unable to merge this PR to start the release process. Thank you!

[fabn]

🎉

Will it be released on rubygems as well or should we point to github?

Thanks for merging this.

[crookedneighbor]

@camlau-pp-dev and @HDLahlou are going to handle releasing it to Rubygems. They can update here when it's available.

[joshcass]

Looks like the payouts sdk will need a gemspec update or anyone using both gems will be unable to install 2.0.0

https://github.com/paypal/Payouts-Ruby-SDK/blob/175338330b6af569ed0787a5a94ac0a584782f86/paypal-payouts-sdk.gemspec#L22

Also, thanks all for addressing this!

[fabn]

The same is true for PayPal checkout SDK https://github.com/paypal/Checkout-Ruby-SDK/blob/develop/paypal-checkout-sdk.gemspec#L22 which unfortunately has just been deprecated 🤦🏻‍♂️

Maybe you should reconsider version bump to 2.0.0 and go with 1.1 or something similar.

[camlau-pp-dev]

Hi everyone, we have just released the 2.0.0 version that can be seen here: https://rubygems.org/gems/paypalhttp/versions/2.0.0

[sweetppro]

will Checkout-Ruby-SDK be updated to use this?

[crookedneighbor]

@sweetppro No, as Checkout-Ruby-SDK is no longer receiving updates. You are welcome to fork it and update it yourself, or collaborate on a community fork of the SDK.

[magni-]

@crookedneighbor Will https://github.com/paypal/Payouts-Ruby-SDK be updated to use this? There's an open dependabot PR doing just that: https://github.com/paypal/Payouts-Ruby-SDK/pull/19