Fix/CGI.escape Function Issue

[camlau-pp-dev]

Overview

• Previously there was a change to the URI.escape function to utilize CGI.escape as shown in this Pull Request: https://github.com/paypal/paypalhttp_ruby/pull/19.

• There was a breaking case with this change, and this PR serves to resolve this.

  • Links such as https://localhost:3001/ were having the special characters be encoded, resulting in http%3A%2F%2Flocalhost%3A3001%2F which is incorrect.

• This change also reverts the functionality for encoding spaces, as CGI would make " " => "+" while this URI Parser replaces spaces with " " => "%20"

  Testing

• Updated unit tests and added a new one to showcase the passing functionality:

• Integration tested this change with the PayPal Checkout-Ruby-SDK with Ruby version 3.0.4 and displayed no failures in unit tests.

  • Manually entered in test strings in the access token request body: https://github.com/paypal/Checkout-Ruby-SDK/blob/develop/lib/core/token_requests.rb#L7-L9
  • Temporarily added a print statement in the FormEncoded.rb file to view the results of the CGI.escape workings.

[hlahlou-pp-dev]

This change also reverts the functionality for encoding spaces, as CGI would make " " => "+" while this URI Parser replaces spaces with " " => "%20"