search

paypal / react-engine

a composite render engine for universal (isomorphic) express apps to render both plain react views and react-router views
Apache License 2.0
1.45k stars 130 forks source link

React 0.14.0 #108

Closed jocubeit closed 8 years ago

jocubeit commented 9 years ago

Is there a timeline for react-engine to use react 0.14.0. I'd like to use this with material-ui but it has a peer dependency on 0.14.0 which means it's not currently possible. Just trying to get a rough timeframe so I can decide which way to go.

samsel commented 9 years ago

@kodemunki please try 2.5.0 of react-engine. we don't force the version of react anymore. as a consumer you should be able to use any version of react. Please let me know.

jocubeit commented 9 years ago

Thanks for the update, it's a step in the right direction. Unfortunately it's a bit of a catch 22 because react-engine doesn't support react-router's version ^1. With this in mind you can't run the examples using React ^0.14. I'll try the version 3 branch. If this works do you have a timeline or milestone for version 3?

icodejs commented 9 years ago

Also the following warning is present when rendering on the server with React 0.14: 

Warning: React.renderToString is deprecated. Please use ReactDOMServer.renderToString from require('react-dom/server') instead.

Which will obviously break when 0.15 is released.

Can you advice on how to move forward and what your plans are, in terms of supporting future versions of React.

samsel commented 9 years ago

@kodemunki @icodejs we are trying to support react 0.14/0.15 with the v3.0 which bumps react-router version to 1.x. In the mean time please use react 0.13. Will update you guys as we progress

dglozic commented 8 years ago

Do you have rough ideas on when v3.0 is due? We would love to drop the workarounds we were forced to use with a pre 1.0 version of react-router

ericelliott commented 8 years ago

:+1: Having trouble using React 0.14 with react-engine, as well. Anything I can help with?

samsel commented 8 years ago

@ericelliott are you facing issues with 3.0 alpha version of react-engine https://github.com/paypal/react-engine/blob/v3.x/package.json#L3 ?

samsel commented 8 years ago

@ericelliott @dglozic @icodejs @JurgenJocubeit

react-engine version 3.0.0-rc.2 is published

It has support for react@0.14 and react-router@1.

You can follow the v3.x README to upgrade. A more precise migration note can be found here.

Please file issues or comment here if you face any difficulties. We are planning to publish 3.x towards the end of next week.

samsel commented 8 years ago

react-engine 3.0.0 has been out for 15 days now. please open separate issues if you encounter anything.

ericelliott commented 8 years ago

I'm using react-router 2.0.0-rc5 now. =)

samsel commented 8 years ago

https://github.com/paypal/react-engine/issues/135