paypal / react-engine

a composite render engine for universal (isomorphic) express apps to render both plain react views and react-router views
Apache License 2.0
1.45k stars 130 forks source link

Bumped react version to 0.14.2 and react-router version to 0.13.5 #112

Closed DPr00f closed 8 years ago

DPr00f commented 8 years ago

Hey guys, I've been having troubles using version 2.6.0 because react-router reports that can't call makeHref of undefined. Version 2.5.0 works fine but gives me a warning Warning: React.renderToString is deprecated. Please use ReactDOMServer.renderToString from require('react-dom/server') instead. So I've updated the code to use react 0.14 and the new version of react-router. This fix the warnings and react-router works properly.

Thanks

DPr00f commented 8 years ago

Ah sorry, don't have time to check why the tests are failing now. Will close the PR.