search

paypal / react-engine

a composite render engine for universal (isomorphic) express apps to render both plain react views and react-router views
Apache License 2.0
1.45k stars 130 forks source link

set implicit extension to import file names #114

Closed dmbrowne closed 8 years ago

dmbrowne commented 8 years ago

I'm getting an error when trying to require('react-engine/lib/client') with systemJS. The issue is that the react-engine/lib/client module is trying to require('./config') but the .json extension hasn't explicitly been set, so it tries to call require('config.js') instead.

Would be able to update the required filenames to include the extensions? I believe this is currently the standard of es6 also (having to explicitly name module extensions)

samsel commented 8 years ago

@dmbrowne sure, I can update that in the next release. thanks

dmbrowne commented 8 years ago

Thank you :)

samsel commented 8 years ago

published v3.1.0 with the change!