search

paypal / react-engine

a composite render engine for universal (isomorphic) express apps to render both plain react views and react-router views
Apache License 2.0
1.45k stars 130 forks source link

Router object not returned from client.boot since 3.0 #127

Closed pklicnik closed 8 years ago

pklicnik commented 8 years ago

Before the 3.x release, calling Client.boot returned the Router object as part of the callback:

// `onBoot` - Function (optional)
// returns data that was used
// during rendering as the first argument
// the second argument is the `router` created behind the scenes
// (only available while using react-router)
client.boot(/* client options object */, function onBoot(data, router) {

});

The changes to react-router 1.0 makes this obsolete, so the doc should be updated

dglozic commented 8 years ago

+1 this request

samsel commented 8 years ago

fixed and released in v3.1.0. thanks!