search

paypal / react-engine

a composite render engine for universal (isomorphic) express apps to render both plain react views and react-router views
Apache License 2.0
1.45k stars 130 forks source link

3.0.0 query string fix #144

Closed JustinMGaiam closed 8 years ago

JustinMGaiam commented 8 years ago

This fix is a proposal for 3.0.1 which applies a fix from the 3.1.0 Express view to 3.0.0 where React Router does not receive the query string values. 3.0.0 does not work if you use query strings in your routes to change which component is displayed. This is a fix for issue #143

samsel commented 8 years ago

@JustinMGaiam this change already exists in the codebase. you can npm install again to get the latest version.

JustinMGaiam commented 8 years ago

@samsel we updated to React Engine 3.1.0 before I issued this PR and it is working, thanks. Any reason you would not want to either apply it to 3.0.0 or remove the tag since that version does not work for query strings? Please see https://github.com/paypal/react-engine/blob/v3.0.0/lib/expressView.js#L35