search

paypal / react-engine

a composite render engine for universal (isomorphic) express apps to render both plain react views and react-router views
Apache License 2.0
1.45k stars 130 forks source link

Update deprecated history and RoutingContext #148

Closed fortezhuo closed 8 years ago

fortezhuo commented 8 years ago

I have found react-engine still using RoutingContext (server.js line : 37) and cause this warning. Warning: [react-router] RoutingContext has been renamed to RouterContext. Please use import { RouterContext } from 'react-router'. http://tiny.cc/router-routercontext

And also still using history object (client.js line : 22) and cause this warning Warning: [react-router] It appears you have provided a deprecated history object to <Router/>, please use a history provided by React Router with import { browserHistory } from 'react-router' or import { hashHistory } from 'react-router'. If you are using a custom history please create it with useRouterHistory, see http://tiny.cc/router-usinghistory for details.

samsel commented 8 years ago

@hedikasmanto will fix this in the next release

remarkablemark commented 8 years ago

@samsel When you get the chance, could you kindly review pull request #155?