fix #151, make react-router optional

paypal / react-engine

a composite render engine for universal (isomorphic) express apps to render both plain react views and react-router views

Apache License 2.0

1.45k stars 130 forks source link

fix #151, make react-router optional #152

Closed vuhwang closed 8 years ago

samsel commented 8 years ago

v3.2.2 has been published with this fix. thanks @vuhwang

grawk commented 8 years ago

I've got 3.3.0 installed. Should this issue be resolved in that minor?

vuhwang commented 8 years ago

@grawk Yes 3.3.0 should have this resolved as well. If you are using browserify you will need to pass in the --im option to ignore react-router not being installed which browserify will attempt to bundle from the require of 'react-engine/lib/client'. Also when you call res.render the view you provide should not start with a /.