safeguard against property over look while fusing together data object and routerProps object in the server render

paypal / react-engine

a composite render engine for universal (isomorphic) express apps to render both plain react views and react-router views

Apache License 2.0

1.45k stars 130 forks source link

safeguard against property over look while fusing together data object and routerProps object in the server render #173

Closed samsel closed 8 years ago

JustinMGaiam commented 8 years ago

@samsel I made additional merge and require changes in this PR https://github.com/paypal/react-engine/pull/172 do we need to bring the PR's together? I was trying to stick to the client lodash require pattern of only import a specific module and not the entire lodash library for consistency.

JustinMGaiam commented 8 years ago

@samsel The approach looks good to me in this PR and I would like to see it merged.

I also have questions around the merge that is still left in lib/server.js as cited in my PR https://github.com/paypal/react-engine/pull/172/files#diff-c945a46d13b34fcaff544d966cffcabaL146