search

paypal / react-engine

a composite render engine for universal (isomorphic) express apps to render both plain react views and react-router views
Apache License 2.0
1.45k stars 130 forks source link

ReactDOM.hydrate breaks React 15 compatibility #206

Closed liddiard closed 6 years ago

liddiard commented 6 years ago

The introduction of ReactDOM.hydrate in #203 breaks usage with React 15 because the hydrate method is not available until React (ReactDOM) 16. On React 15, pages crash during render with Uncaught TypeError: ReactDOM.hydrate is not a function.

Since React 15 and 16 are both listed as valid peerDependences, support for ReactDOM.render should be reintroduced, probably with a conditional. (If hydrate is available, use it, otherwise use render.) Or if React 15 is no longer going to be supported, it should be removed from peerDependencies.

chuanhhoang commented 6 years ago

Any update on this problem? When trying to withdraw my fund I faced this exact problem. https://i.imgur.com/bSs8B1g.jpg

liddiard commented 6 years ago

Looks like #207 fixes it. @samsel, can you merge?

samsel commented 6 years ago

this has been published as 4.5.1, thanks.

aneeshvaidya commented 6 years ago

I believe this issue can be closed now