search

paypal / react-engine

a composite render engine for universal (isomorphic) express apps to render both plain react views and react-router views
Apache License 2.0
1.45k stars 130 forks source link

react-router moved to dependency of react engine #209

Closed ryanbas21 closed 6 years ago

ryanbas21 commented 6 years ago

Currently we need react-router as dependency in our repo even though we don't use react-router. figured we can just move it to be a dep of react-engine instead.

samsel commented 6 years ago

@grawk or someone from the team, can you help take this & https://github.com/paypal/react-engine/pull/208 forward?

cerebrl commented 6 years ago

I discussed this with the team, and I feel the underlying problem that this is trying to fix requires a different solution. I'm recommending we close this PR, and I'll create a new PR with a different solution.