search

paypal / react-engine

a composite render engine for universal (isomorphic) express apps to render both plain react views and react-router views
Apache License 2.0
1.45k stars 130 forks source link

Improving server side error handling #90

Open slatkovic opened 9 years ago

slatkovic commented 9 years ago

In a case of an error on the server side, the next middleware in chain is called without logging the error. In some cases the rendering logic silently fails and it's hard to debug rendering issues. An example would be rendering a template from an existing error middleware.

Suggested improvement: Adding a debug statement in the catch block.

samsel commented 9 years ago

@slatkovic are you suggesting to add something like debuglog? A PR would be awesome. if not, will address this as soon as we get done with making react-engine compatible with react-router 1.x