#613 Add withAttributes/removeAttributes methods

paypal / squbs

Akka Streams & Akka HTTP for Large-Scale Production Deployments

http://paypal.github.io/squbs

Apache License 2.0

1.43k stars 237 forks source link

#613 Add withAttributes/removeAttributes methods #655

Closed crankydillo closed 6 years ago

crankydillo commented 6 years ago

See #613 for info.

[x] Title includes issue id.
[x] Description of the change added.
[x] Commits are squashed.
[x] Tests added.
[ ] Documentation added/updated.
[x] Also please review CONTRIBUTING.md.

crankydillo commented 6 years ago

I'm unsure why this last push, which was a squashed commit that removed an unused trait from the changed spec, failed. The previous CI run did not fail.

I tracked the failure to the following and am not sure if it's intermittent.

[info] - should share the circuit breaker state across materializations *** FAILED ***
[info]   14 was not less than or equal to 12 (ClientFlowCircuitBreakerSpec.scala:259)

Running the tests locally pass.

akara commented 6 years ago

Shall we need doc updates for this? The doc updated marker is off.

crankydillo commented 6 years ago

I switched Scala to tuples. RE docs, I thought about that. I should have checked, but I just ASSumed you didn't document every method:)

crankydillo commented 6 years ago

@anilgursel I addressed the vararg issue.