paypal / squbs

Akka Streams & Akka HTTP for Large-Scale Production Deployments
http://paypal.github.io/squbs
Apache License 2.0
1.43k stars 237 forks source link

Type parameter consistency: I, O, and C #679

Open crankydillo opened 6 years ago

crankydillo commented 6 years ago

Recently, I was trying to get my mind around Retry and ClientConnectionFlow. For the former, the type annotations are good; however, I think they should be changed to match akka-streams conventions (I instead of In and O instead of Out).

I propose C is used for the 'context' type parameter (ClientConnectionFlow[C] instead ClientConnectionFlow[T]). Of course, this is only true if it should have this 'context' meaning. If it really is any type, I would stick with T. However, I wouldn't use T in one place and Context in another.