search

paypal / squbs

Akka Streams & Akka HTTP for Large-Scale Production Deployments
http://paypal.github.io/squbs
Apache License 2.0
1.43k stars 237 forks source link

690 retrystage logging improvements #698

Closed crankydillo closed 5 years ago

crankydillo commented 5 years ago

690 When RetryStage cannot find a match, log an error message and propagate the result regardless of whether or not it failed.

crankydillo commented 5 years ago

I think this is the failure text:

Total records processed => (100093,100101)
[info] - should recover from unexpected stream shutdown *** FAILED ***
[info]   100093 was not greater than or equal to 100100 (BroadcastBufferSpec.scala:259)
00:16:17.030 [pool-1-thread-1-ScalaTest-running-BroadcastCharBufferSpec] DEBUG net.openhft.chronicle.bytes.MappedFile - Allocation of 0 chunk in /tmp/persistent_queue4074034160037773566/directory-listing.cq4t took 0.091 ms.
00:16:17.055 [pool-1-thread-1-ScalaTest-running-BroadcastCharBufferSpec] DEBUG net.openhft.chronicle.bytes.MappedFile - Allocation of 0 chunk in /tmp/persistent_queue4074034160037773566/directory-listing.cq4t took 0.043 ms.
00:16:17.067 [BroadcastCharBufferSpec-akka.actor.default-dispatcher-2] DEBUG net.openhft.chronicle.bytes.MappedFile - Allocation of 0 chunk in /tmp/persistent_queue4074034160037773566/20190130-001617.cq4 took 0.182 ms.
00:16:17.067 [BroadcastCharBufferSpec-akka.actor.default-dispatcher-2] INFO org.squbs.pattern.stream.PersistentQueue - File acquired 1548807377 - /tmp/persistent_queue4074034160037773566/20190130-001617.cq4
00:16:17.068 [BroadcastCharBufferSpec-akka.actor.default-dispatcher-2] INFO org.squbs.pattern.stream.PersistentQueue - File acquired 1548807377 - /tmp/persistent_queue4074034160037773566/20190130-001617.cq4
00:16:17.069 [BroadcastCharBufferSpec-akka.actor.default-dispatcher-2] DEBUG net.openhft.chronicle.bytes.MappedFile - Allocation of 0 chunk in /tmp/persistent_queue4074034160037773566/tailer.idx took 0.084 ms.
Restart from count 30017
00:16:17.630 [pool-1-thread-1-ScalaTest-running-BroadcastCharBu

which I hope is unrelated to this work.

crankydillo commented 5 years ago

close/reopen to try again.

sebady commented 5 years ago

The travis pr jobs failures are not related to this change.

sebady commented 5 years ago

Some minor comments. Looks good to me.