#746: First trial with github actions

paypal / squbs

Akka Streams & Akka HTTP for Large-Scale Production Deployments

http://paypal.github.io/squbs

Apache License 2.0

1.43k stars 237 forks source link

#746: First trial with github actions #747

Closed JaySucharitakul closed 2 years ago

JaySucharitakul commented 2 years ago

Thanks for your pull request. Please review the following guidelines.

[x] Title includes issue id.
[x] Description of the change added.
[x] Commits are squashed.
[ ] Tests added.
[ ] Documentation added/updated.
[x] Also please review CONTRIBUTING.md.

akara commented 2 years ago

@agursel as we discussed offline, I'll approve and merge this PR first to ensure we can actually build with GitHub actions. Then we'll improve upon it in a subsequent PR. I know it is a little dirty but @JaySucharitakul cannot even test the real thing without this step. Please let me know if you disagree. Thanks!

Also CC @sebady.

anilgursel commented 2 years ago

No objection. But, the token is probably needed to be deleted before we merge. Shouldn't it?

akara commented 2 years ago

That's an old encrypted token. We may need to generate a new one anyway. But sure, let's have that deleted. Thanks!

@JaySucharitakul kindly remove the encrypted tokens (even commented out) and push your changes. We need to see that it builds. Then please open another PR for the left-over work.