paypay / paypayopa-sdk-php

With PayPay's Payment SDK, you can build a custom Payment checkout process to suit your unique business needs and branding guidelines
http://developer.paypay.ne.jp/
Apache License 2.0
16 stars 11 forks source link

use {$var} instead of ${var} #393

Open fuwasegu opened 6 months ago

fuwasegu commented 6 months ago

Starting with PHP 8.2, there is a deprecated notation for embedding variables in strings Reference: https://www.php.net/manual/en/migration82.deprecated.php

In this repository, there was an embedding using ${var}, which has been corrected to {$var}.

All Submissions:

New Feature Submissions:

Changes to Core Features:

CLAassistant commented 6 months ago

CLA assistant check
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.
You have signed the CLA already but the status is still pending? Let us recheck it.

sonarcloud[bot] commented 6 months ago

Quality Gate Failed Quality Gate failed

Failed conditions
B Reliability Rating on New Code (required ≥ A)
D Maintainability Rating on New Code (required ≥ A)

See analysis details on SonarCloud

Catch issues before they fail your Quality Gate with our IDE extension SonarLint

fuwasegu commented 6 months ago

I seem to be getting sonarcloud errors It is true that the file I modified seems to be the target of the check, but my modification has nothing to do with it.

Is this a problem I should fix?