search

payprop / html-googlemaps-v3

Fork of HTML::GoogleMaps to fix issues
2 stars 1 forks source link

Fixes scrolling #10

Closed nigelhorne closed 7 years ago

nigelhorne commented 7 years ago

Scrolling a page would put the map in front of a CSS fixed element. This code makes that behaviour optional.

nigelhorne commented 7 years ago

In hindsight the space between %s %s wasn't needed, it can be:

    my $map = sprintf(
        '<div id="%s" style="width: %s; height: %s%s"></div>',
        @{$self}{qw/ id width height / },
        exists($self->{'z_axis'})
            ? '; z-axis: ' . $self->{'z_axis'} : ''
    );
coveralls commented 7 years ago

Coverage Status

Coverage increased (+0.03%) to 97.468% when pulling aa541c291a21b8301701a151465ce92d6c631ed0 on nigelhorne:master into bcd155ad5c31f7b0706edf3b77f449a737dd62bc on Humanstate:master.

leejo commented 7 years ago

Squashed and merged, thanks! Will push out an update to CPAN shortly.

nigelhorne commented 7 years ago

Sweet. Thank you.

leejo commented 7 years ago

Thank you for the contributions 😃 - i've added you to the list of contributors: https://github.com/Humanstate/html-googlemaps-v3/commit/e6245ceee1c2ee97e1c41d91cd622f74e283b35b#diff-ec59dd84d8ad51d62a8ea9abffc4755bR408