search

payprop / html-googlemaps-v3

Fork of HTML::GoogleMaps to fix issues
2 stars 1 forks source link

Scrolling trick #6

Closed nigelhorne closed 7 years ago

nigelhorne commented 7 years ago

I have no idea if this is your problem or mine, but I'm putting this in here in case you can help. Please take a look at

https://genealogy.nigelhorne.com/cgi-bin/page.fcgi?page=people&entry=I5

Now scroll up until you get the map, then scroll up more and you'll see that the map goes in front of, rather than behind, the banner. Any ideas?

leejo commented 7 years ago

Almost certainly a problem with CSS / page layout and i don't think this is related to the module.

nigelhorne commented 7 years ago

The fix is to change this:

    my $map = sprintf(
        '<div id="%s" style="width: %s; height: %s"></div>',
        @{$self}{qw/ id width height / },
);

to 

    my $map = sprintf(
        '<div id="%s" style="width: %s; height: %s; z-index: -1"></div>',
        @{$self}{qw/ id width height / },
);

That probably should be configurable. Would you like a patch?

leejo commented 7 years ago

That probably should be configurable. Would you like a patch?

Yep, create a PR and i'll merge it.