search

payprop / net-oauth2-authorizationserver

Module to implement core functions of an OAuth2 authorization server
7 stars 10 forks source link

Lintian: fix interpreter path #18

Closed dr0jf closed 6 years ago

dr0jf commented 6 years ago

When building a Debian package, lintian complains about the interpreter path. I have to patch it for Debian and send the patch upstream, if you don't want to merge it that's fine.

coveralls commented 6 years ago

Coverage Status

Coverage remained the same at 97.906% when pulling 2d8fbec5b8e89f326f41ab5c817714841d1c9e67 on dr0jf:lintian-fix-interpreter-path into fcb72db66fddb403bcba573d5a1c8f630254082c on Humanstate:master.

coveralls commented 6 years ago

Coverage Status

Coverage remained the same at 97.906% when pulling 2d8fbec5b8e89f326f41ab5c817714841d1c9e67 on dr0jf:lintian-fix-interpreter-path into fcb72db66fddb403bcba573d5a1c8f630254082c on Humanstate:master.

coveralls commented 6 years ago

Coverage Status

Coverage remained the same at 97.906% when pulling 2d8fbec5b8e89f326f41ab5c817714841d1c9e67 on dr0jf:lintian-fix-interpreter-path into fcb72db66fddb403bcba573d5a1c8f630254082c on Humanstate:master.

leejo commented 6 years ago

Can you set this to /usr/bin/env perl rather than /usr/bin/perl ? I don't use the system perl so need the perl binary that's in my $PATH var.

dr0jf commented 6 years ago

Debian policy does not allow that.

§5.1 "All packaged perl programs must start with #!/usr/bin/perl and may append such flags as are required. "[1]

Reasons behind this can be found in an older discussion on the Debian mailing list.[2]

[1] https://www.debian.org/doc/packaging-manuals/perl-policy/ch-programs.html#s-hash-bang [2] https://lists.debian.org/debian-perl/2012/07/msg00138.html

leejo commented 6 years ago

Interesting, thanks. Makes sense from a dist's point of view although I try to avoid the dist provided perl where possible. I'll merge this as the scripts affected by the change are just examples and not used within any of the code and it will fix your lintian warnings. Thanks!

leejo commented 6 years ago

v0.18 on its way to CPAN shortly, thanks again!

dr0jf commented 6 years ago

Thanks! In general, it's possible to have patches in the Debian package if there is something you do not want to merge. But the idea is to always offer patches we do.

leejo commented 6 years ago

Thanks! In general, it's possible to have patches in the Debian package if there is something you do not want to merge. But the idea is to always offer patches we do.

I appreciate it when dist/package maintainers send patches upstream, so thanks!