search

payprop / net-oauth2-authorizationserver

Module to implement core functions of an OAuth2 authorization server
7 stars 10 forks source link

Remove hard dependency on Mojo::JWT #26

Closed ap closed 4 years ago

ap commented 4 years ago

The hard dependency on Mojo::JWT ends up dragging in Mojolicious… which is annoying when one wants to use this module with another framework. 🙂

It’s conceivable to declare Mojo::JWT as a test-only non-runtime dependency, if the test is supposed to always be run. But to me it doesn’t seem like the kind of test that needs to be. It seems sufficient for this test to get run during development only.

coveralls commented 4 years ago

Coverage Status

Coverage decreased (-0.3%) to 97.206% when pulling 6a2c90e26112e38d2ca1765e903579912046f0cd on ap-contrib:mojo-undep into 37342ffddaffaa9f6d188c03f97683200526d52c on Humanstate:master.

leejo commented 4 years ago

Looks good đź‘Ť Will get this merged and deployed to CPAN tomorrow.

leejo commented 4 years ago

v0.24 on its way to CPAN.

ap commented 4 years ago

Gracias!