search

payscale / country-currency-map

Mapping of countries and their primary currency.
Apache License 2.0
22 stars 15 forks source link

Release uses non-compiled version #32

Open rchl opened 4 years ago

rchl commented 4 years ago

Why are you compiling the code and at the same time have main set to uncompiled version? https://github.com/payscale/country-currency-map/blob/b08a150d26fcb61def61ed09f65cc9eaffc02c76/package.json#L5

That means that users are gonna use an uncompiled version if they import directly from the module.

Also, when using a compiled version, don't include original sources in released package to make the package smaller.

rchl commented 4 years ago

Well, I see that both lib and dist are compiled (by babel and webpack respectively). Still, I don't understand the reasoning and I don't think that's correct.