search

paysera / lib-money

Library to manipulate Money
MIT License
7 stars 9 forks source link

Drop support for PHP 5.6 #24

Closed borilyordanov closed 1 year ago

borilyordanov commented 2 years ago
daniel-valchev-paysera commented 1 year ago

PHPUnit 9 will not allow us to run the tests under PHP versions < 7.3. The library supports PHP >= 5.6 according to the composer.json file. It's already time to drop the support of PHP 5 but it's good to have tests running under PHP < 7.3 if we still want to support these versions. Using multiple PHPunit versions, ^6.5 || ^9.6 to be specific, can solve the issue relatively easily.

Do you think it's worth the investment to make our tests able to run under old PHP versions or the plan is to drop support for them anyway?

borilyordanov commented 1 year ago

I've decided to remove support for PHP 5.6.