Deprecate and mark methods as internal

paysera / lib-money

Library to manipulate Money

MIT License

7 stars 9 forks source link

Deprecate and mark methods as internal #25

Closed borilyordanov closed 1 year ago

borilyordanov commented 2 years ago

Deprecate the following methods:

Money::setAmountInCents() in favor of Money::setAmountInMinorUnits();
Money::getAmountInCents() in favor of Money::getAmountInMinorUnits().

Mark the following methods as @internal:

Money::setAmount();
Money::setCurrency();
Money::setAmountInCents();
Money::setAmountInMinorUnits().

daniel-valchev-paysera commented 1 year ago

Are these changes going to be released as a separate release or they will be grouped with something else? Should we add the changes to the changelog, perhaps in the unreleased section?

borilyordanov commented 1 year ago

The new release most probably will contain several changes. Usually it is not necessary to expect from contributors to manage the changelog themselves. Nevertheless, I've added the changes as unreleased.