paytm / lgr

Generic Logger
MIT License
2 stars 7 forks source link

Let's not cheat on travis builds #17

Closed SirR4T closed 8 years ago

SirR4T commented 8 years ago

Travis did indeed report a build error earlier, when using https:// url for npmlog. I did not debug the error, but instead found a workaround: update to latest npm before building.

Since this approach is not backward compatible (we are still using older versions of node and npm in production), let's remove this hack, so that Travis would indeed report build errors.

coveralls commented 8 years ago

Coverage Status

Coverage remained the same at 98.276% when pulling 87bb583166208d6758386a150c916a6ee51692c6 on fixTravisBuilds into 619207380340ae6c818d7659487cf8502bc256af on master.