paytm / lgr

Generic Logger
MIT License
2 stars 7 forks source link

Buffering functionality added based upon buffer size as well as time. #34

Closed abhishekRana01 closed 8 years ago

abhishekRana01 commented 8 years ago

Buffering functionality added based upon buffer size as well as time. Test cases modified to test for same.

coveralls commented 8 years ago

Coverage Status

Coverage decreased (-0.09%) to 96.532% when pulling d4a654d5503288be9e02ce7167357180212f46fa on a-rana93:master into cc476537c14c220a2ae2f08abc1646dca11e62ac on paytm:master.

coveralls commented 8 years ago

Coverage Status

Coverage increased (+1.6%) to 98.266% when pulling 84ad613f78d1493f9569f118fc8868aed562c4fe on a-rana93:master into cc476537c14c220a2ae2f08abc1646dca11e62ac on paytm:master.

coveralls commented 8 years ago

Coverage Status

Coverage increased (+0.5%) to 97.11% when pulling 4ad9b7c873fdd0b6e586e02cdb8c22579f1dfa79 on a-rana93:master into cc476537c14c220a2ae2f08abc1646dca11e62ac on paytm:master.

SirR4T commented 8 years ago

@a-rana93 I suspect coveralls is unable to detect coverage in bufferedWrite.js, as the source isn't available in this repo. I suggest you push a branch on to paytm/lgr, for better coverage analysis.

abhishekRana01 commented 8 years ago

@SirR4T coveralls does detect 100% coverage in bufferedWrite.js. You can refer to the output of coveralls by clicking on black/green button above (which will further take you to url https://coveralls.io/builds/6850573/source?filename=bufferedWrite.js)

SirR4T commented 8 years ago

oops, my bad 😁